Re: compile warnings from CVS

[Scott Klement <klemscot@xxxxxxxxxxxx>]

Hi Mike,

> Hi Shawn,
> 
> I don't get either error on either UnixWare 7 or TurboLinux 6.  I would
> suggest checking out fresh, and also make sure you don't have any old
> header files or anything lying around.
> 
> Mike
> 

Hmmm... I'm getting these warnings, just as Sean is... even after a fresh
checkout. They're just warning messages, so the app still compiles and
runs.  So I took a look at them...

> > 
> > session.c: In function `tn5250_session_send_error':
> > session.c:209: warning: passing arg 4 from incompatible pointer type
> > 

Line 209 of session.c is:

  tn5250_stream_send_packet(This->stream, 4, header, &errorcode);

and looking to see what errorcode is, you'll see that its an unsigned
long.  telnet_stream_send_packet(), accepts a pointer to unsigned char
instead of unsigned long -- so the "incorrect pointer type" message
does make sense.

> > utility.c: In function `tn5250_char_map_printable_p':
> > utility.c:373: warning: unreachable code at beginning of switch
> > statement

Likewise, around line 373 of utility.c, you'll find:

int tn5250_char_map_printable_p(Tn5250CharMap *map, Tn5250Char data)
{
   switch (data) {
     /*
        Ideographic Shift-In and Shift-Out.
   case 0x0e:
   case 0x0f:
     */
      return 0;
   }
   return 1;
}

Its pretty obvious that the "return 0" in in the switch() group above
can't be reached, since there are no case statements preceding it.

So... the warnings make perfect sense...  ;-)   Though, they don't seem
to be hurting anything.  Its curious that neither Unixware or TurboLinux
wouldnt report these.  Is your copy of the source out of sync w/CVS?


+---
| This is the LINUX5250 Mailing List!
| To submit a new message, send your mail to LINUX5250@midrange.com.
| To subscribe to this list send email to LINUX5250-SUB@midrange.com.
| To unsubscribe from this list send email to LINUX5250-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: david@midrange.com
+---