Re: Code review?

[Alan Shore <AlanShore@xxxxxxxx>]

Hi Steve
we don't do code review, for multiple reasons, of which the most important
one (in my opinion) is that there is more than one way to skin a cat, and
with "personalized" programming, programmers tend to be ticked off when
someone suggests a different method of obtaining the same result.
What we DO have in place is a group of QA testers
I've found that programmers make the lousiest testers. They tend to test to
prove their changes work. They tend to NOT test to break the program.
The QA testers job is to try and break the program
What this also forces a programmer to do is to document (from a users
perspective) the changes made to the program, and what results should be
expected.


Alan Shore
Programmer/Analyst, Distribution
E:AShore@xxxxxxxxxxx
P:(631) 200-5019
C:(631) 880-8640
"If you're going through Hell, keep going" - Winston Churchill

midrange-l-bounces@xxxxxxxxxxxx wrote on 04/08/2009 09:38:56 AM:

> Is anyone doing code review on new or modified code before moving it to
> production?  If so, what is your process?  Who participates in the code
> review?  How ticked off do the programmers get when someone doesn't like
> their code?  Pros?  Cons?
>
> It seems to me that you would have to have shop standards and review the
> code versus the shop standard rather than having everyone in the review
tell
> how 'they' would've coded the program.
>
> All opinions welcomed.
>
> Thanks,
>
> Steve
>
>
> --
> This is the Midrange Systems Technical Discussion (MIDRANGE-L) mailing
list
> To post a message email: MIDRANGE-L@xxxxxxxxxxxx
> To subscribe, unsubscribe, or change list options,
> visit: http://lists.midrange.com/mailman/listinfo/midrange-l
> or email: MIDRANGE-L-request@xxxxxxxxxxxx
> Before posting, please take a moment to review the archives
> at http://archive.midrange.com/midrange-l.