Modify caller or callee?

[David FOXWELL <David.FOXWELL@xxxxxxxxx>]

Adapted from a real-life case :


GetClient  (ClientID);

If client_hair_brown and
   client_blue_eyes;
   Admit_Client ( ClientID ); // external subprocedure

Endif;


// Admit_Client
GetClient  (ClientID);
DoStuff();


Modification : Admit_Client must not be performed if client has long hair.


Does the modification go in Admit_Client, eg,
// Admit_Client
GetClient  (ClientID);
If client_hair_long;
   return;
Else;
    DoStuff();
Endif;


Or in all the callers?
If client_hair_brown and
   client_blue_eyes and
    not client_hair_long;
   Admit_Client ( ClientID ); // external subprocedure

Endif;





This would mean duplication of code, but putting the modification in Admit_Client could be misleading to the person reading the caller's code.


Thanks.