RPG IV program - comments requested

[Jim Langston <jlangston@xxxxxxxxxxxxxxxx>]

This is a small update utility I just created for one of my users.  All
it does is
goes through a file and changes one field (BSSCAC) when another filed is

equal to an input value (BSXTRL).

There are two input parameters, Trailer and SCACCode.  Trailer is the
search
criteria.

I would request critiquing of this program.  That is, I am using D specs
to declare
my variables, I am using a PLIST to declare my entry parameters and I am
using
the RPG Cycle to cycle through all my records.

Since I am just starting to program in RPGLE I do not want to get any
bad habits
started now.  I would rather start of on the right foot.

So I guess I am asking, if you were to write this same program, is this
the way you
would code it?

Regards,

Jim Langston

     FBSSHIPX   UP   E             DISK

     DTrailer          S             10A
     DSCACCode         S              4A

     C                   IF        Trailer = BSXTRL
     C                   EVAL      BSSCAC = SCACCode
     C                   UPDATE    BSSHIPX1
     C                   ENDIF

      *******************************
      *** Set up Entry Parameters ***
      *******************************
     C     *INZSR        BEGSR
     C
     C     *ENTRY        PLIST
     C                   PARM                    Trailer
     C                   PARM                    SCACCode
     C
     C                   ENDSR


+---
| This is the RPG/400 Mailing List!
| To submit a new message, send your mail to RPG400-L@midrange.com.
| To subscribe to this list send email to RPG400-L-SUB@midrange.com.
| To unsubscribe from this list send email to RPG400-L-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: david@midrange.com
+---