RE: Indicator enhancements (was Bale, Dan)

[Scott Mildenberger <Smildenber@xxxxxxxxxxxx>]

Dan,

That creates a possibility of misspelling the literal.  That could create
errors that can be very difficult to find.  IMO it is much better to use the
constants.  If you spell it incorrectly the compiler will find it.

Scott Mildenberger

> -----Original Message-----
> From: Bale, Dan [SMTP:DBale@TFSA.Textron.com]
> Sent: Wednesday, March 08, 2000 1:02 PM
> To:   'RPG400-L@midrange.com'
> Subject:      RE: Indicator enhancements (was Bale, Dan)
> 
> Me, I'd just junk the defined constants and use literals in the
> expression.
> That way I don't have to bother looking up the D-specs to see how the
> constants are defined.
> 
> C              Eval     RtnCode = MyProc( MyParm )
> C              Select
> C              When     RtnCode = 'ExistingCust'
>  * Perform existing customer processing
> C              When     RtnCode = 'NewCust'
>  * Perform new customer processing
> C              When     RtnCode = 'Error'
> 
> -----Original Message-----
> From: bmorris@ca.ibm.com [mailto:bmorris@ca.ibm.com]
> Sent: Wednesday, March 08, 2000 2:12 PM
> To: RPG400-L@midrange.com
> Subject: Re: Indicator enhancements (was Bale, Dan)
> 
> >Date: Tue, 07 Mar 2000 17:07:10 -0600
> >From: Gary Guthrie <GaryGuthrie@home.com>
> >
> > I submit it might be clearer to:
> >
> >D Error        S      N  Inz( *Negative )
> >D ExistingCust S      N  Inz( *Positive )
> >D NewCust      S      N  Inz( *Off )
> >C              Eval     RtnCode = MyProc( MyParm )
> >C              Select
> >C              When     RtnCode = ExistingCust
> > * Perform existing customer processing
> >
> >C              When     RtnCode = NewCust
> > * Perform new customer processing
> >
> >C              When     RtnCode = Error
> > ...
> 
> Gary, I don't see that *NEGATIVE appears to have general
> usefulness.  Aside from that, indicators hold boolean values.
> If you want to return more than 2 different values, use a
> type that has more than 2 values, and use named constants
> for your special values, in both your procedure and its
> callers.
> 
> D Error        C         -1
> D ExistingCust C         1
> D NewCust      C         0
> 
> C              Eval     RtnCode = MyProc( MyParm )
> C              Select
> C              When     RtnCode = ExistingCust
>  * Perform existing customer processing
> C              When     RtnCode = NewCust
>  * Perform new customer processing
> C              When     RtnCode = Error
>  ...
> 
> +---
+---
| This is the RPG/400 Mailing List!
| To submit a new message, send your mail to RPG400-L@midrange.com.
| To subscribe to this list send email to RPG400-L-SUB@midrange.com.
| To unsubscribe from this list send email to RPG400-L-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: david@midrange.com
+---