Re: How do you read this code ?

["Douglas Handy" <dhandy@xxxxxxxxx>]

> the free form converter does not change things much - does not add
> parentheses - and/or precedence still controls it - and we are still
> left with Joe's observation - this is a do-nothing condition, it seems.

While I agree Joe's observation means his simple one-liner performs the
equivalent function of the existing code, the fact they tried to setup the
IF construct makes me suspect the code isn't working as originally
intended.  So Joe's simplified version may just be maintaining a previously
undetected bug.

If I saw something like that in code, before simplifying to Joe's method I
think it would be prudent to try to find out what the various fields and
codes mean and whether a (different and corrected) form of the IF statment
should be implemented.  Using free form and parentheses around each AND set
and new lines for each OR condition can make the corrected code much easier
to follow.

Long live free format.  :)

Doug