Re: Multiple Conditions on a DOW loop

["Dave" <dave@xxxxxxxxxxxx>]

Maybe it is just me, and I know it is a style choice, but I prefer parens if 
there is more than one condition being tested.

It makes it a lot clearer to read (to me), especially if the comparisons get 
a little complex with multiples ands/ors.

I would have written it like this:
dow (shopDays(DDYIndex) <> '') and (shopDays(DDYIndex) <> 'A');

For the benefit of coders coming behind me, I think I would have also used 
some name constants in the comparison:  cWorkDay, cHoliday, cWeekend, 
cAltWorkDay....

Dave

--------------------------------------------------
From: "Bryce Martin" <BMartin@xxxxxxxxxxxx>
Sent: Saturday, June 13, 2009 7:13 AM
To: "RPG programming on the IBM i / System i" <rpg400-l@xxxxxxxxxxxx>
Subject: Re: Multiple Conditions on a DOW loop

> I removed the parens and it worked.  I don't know.  I can't figure out why
> it would not work yesterday, then today I add the parens, recompile then
> it works.  Then I remove the parens, recompile, and it works again.  Who
> knows.  It now works as I expect that it should have.