RE: Problem with non QUALIFIED DS

[David FOXWELL <David.FOXWELL@xxxxxxxxx>]

> -----Message d'origine-----
> [mailto:rpg400-l-bounces@xxxxxxxxxxxx] De la part de Charles Wilt
> Envoyé : mercredi 23 septembre 2009 20:35
> The problem is the MyDS is a very poor name!
>
> I often have DS's in a copy member without wrapping them in
> /if defines.  But I give my DSs a usable name and following
> the idea of DRY (Don't Repeat Yourself) a DS of a given name
> is only defined in one place.

How about this kind of thing :
MyMod
     D MyModDs1     E DS                   EXTNAME(myfile)
     D                                     QUALIFIED
     D                                     OCCURS(ElementsMyModDS1)
     D ElementsMyModDS1...
     D                S                    100

     D MyModDs2 etc

Would you also put the number of elements here?

> If for some reason, as DS is needed in two places (a good
> example, is the errorDS I use for IBM API's) then I pull it
> out of it's original place an put it into it's own copy book,
> which is then /included into the copy books that need them.

It's not that the DS were needed twice that was the problem. It's the fact that some field names of the external files both had the same field names in the DDS.

> Like Duane, I use /if defined at the top of a copy book so
> that for any given copy book, it is only ever included once.

Well, at least that's one thing I'm doing right already.

Thanks to everyone for their input.