Re: Do you do formal code reviews?

We are looking at having code reviews here - one of the benefits that I don't remember being stated in this thread is that another set of eyes may be able to suggest newer techniques - implied in this post, I see.

We don't have a huge group here, we shall see if this actually happens. I know that I do appreciate someone else being a blank wall for my thinking at times.

Vern

On 11/16/2011 8:47 AM, RNewton@xxxxxxxxxxxxxxxxx wrote:

Thanks everyone for their input. I see the majority here are smaller shops
it or one man consulting firms so I can see why there are not any code
reviews needed. Our needs are a little different however.

We are implementing coding standards in our shop and will be enforcing
those standards with regular code reviews. Our shop has 30+ RPG
developers, each with their own styles and techniques varying from
techniques considered old 15 years ago to some guys counting the days
until 7.1 gets installed to get DB2 ALIAS in externally described data
structures.

We have ever expanding presentation technologies that our business logic
in RPG must be able to support. If we do not have code reviews, we will
continue to see business logic tied up in interactive programs and not
pulled out to service programs for reuse from other interactive
applications, web pages, web services, stored procedures, desktop
applications, etc...

Modernizing a shop this size without code reviews and shop standards for
techniques and syntax styling would be impossible (as we have shown over
the years).

Thanks,
Robert Newton
Estes IT
System Architect
804-353-1900 x2256
rnewton@xxxxxxxxxxxxxxxxx



From:
"Norm Dennis"<nhdennis@xxxxxxxxxxx>
To:
rpg400-l@xxxxxxxxxxxx
Date:
11/15/2011 10:36 PM
Subject:
Re: Do you do formal code reviews?
Sent by:
rpg400-l-bounces@xxxxxxxxxxxx



Haven't even heard formal code reviews mentioned since the early 80's.

Norm Dennis



----- Reply message -----
From: Rick.Chevalier@xxxxxxxxxxxxxxx
Date: Wed, Nov 16, 2011 07:07
Subject: Do you do formal code reviews?
To:<rpg400-l@xxxxxxxxxxxx>

We have talked about doing it but the idea never seems to get much
traction.

-----Original Message-----
From: rpg400-l-bounces@xxxxxxxxxxxx [mailto:rpg400-l-
bounces@xxxxxxxxxxxx] On Behalf Of RNewton@xxxxxxxxxxxxxxxxx
Sent: Tuesday, November 15, 2011 3:13 PM
To: RPG programming on the IBM i / System i
Subject: Re: Do you do formal code reviews?

I take it no one here does code reviews in their shop?

Robert Newton
Estes IT
System Architect
804-353-1900 x2256
rnewton@xxxxxxxxxxxxxxxxx



From:
RNewton@xxxxxxxxxxxxxxxxx
To:
RPG programming on the IBM i / System i<rpg400-l@xxxxxxxxxxxx>
Date:
11/11/2011 08:55 AM
Subject:
Do you do formal code reviews?
Sent by:
rpg400-l-bounces@xxxxxxxxxxxx



How does your shop implement code reviews for ensuring quality and
enforcing coding standards?

Do you have software to manage the process and what are the metrics that
you collect?

Thanks,
Robert Newton
Estes IT
System Architect
804-353-1900 x2256
rnewton@xxxxxxxxxxxxxxxxx



For 80 Years ? Delivering Solutions that Exceed Expectations.



This communication and any transmitted documents are intended to be
confidential. If there is a problem with this transmission, please

contact

the sender. If the reader of this message is not the intended recipient,
or the employee or agent responsible to deliver it to the intended
recipient, you are hereby notified that any dissemination, distribution

or

copying of this communication is strictly prohibited.

--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing
list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.







For 80 Years ? Delivering Solutions that Exceed Expectations.



This communication and any transmitted documents are intended to be
confidential. If there is a problem with this transmission, please

contact

the sender. If the reader of this message is not the intended recipient,
or the employee or agent responsible to deliver it to the intended
recipient, you are hereby notified that any dissemination, distribution

or

copying of this communication is strictly prohibited.

--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing

list

To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

Privileged and Confidential. This e-mail, and any attachments there to,
is intended only for use by the addressee(s) named herein and may contain
privileged or confidential information. If you have received this e-mail
in error, please notify me immediately by a return e-mail and delete this
e-mail. You are hereby notified that any dissemination, distribution or
copying of this e-mail and/or any attachments thereto, is strictly
prohibited.