Re: Technique critique?

On 18-May-2016 14:35 -0500, Alan Shore wrote:

This is code from an existing program in production

RCVF RCDFMT(DVS100) OPNID(*NONE)
Dowhile COND(&EOF *NE '1')

The subject does mention critique ;-)

FWiW: if (&EOF) is *LGL data-type, then also available:

DoWhile COND(*NOT &EOF)

CHGVAR VAR(&CLIB) VALUE(&DVSLB)
IF COND(&CLIB *NE 'NHPROD') THEN(CALLSUBR +
SUBR(EXSUBR))
RCVF RCDFMT(DVS100) OPNID(*NONE)
MONMSG MSGID(CPF0864) EXEC(CHGVAR VAR(&EOF) +
VALUE('1'))
Enddo

FWiW; if only to prevent an error on empty-file by eliminating the /priming/ read, but also perhaps to make the code more succinct having eliminated both that and use of (&EOF), per coding a Do-Forever with LEAVE:

Dowhile COND('1') /* do forever */
RCVF RCDFMT(DVS100) OPNID(*NONE)
MONMSG MSGID(CPF0864) EXEC( LEAVE ) /* leave on EOF */
CHGVAR VAR(&CLIB) VALUE(&DVSLB)
IF COND(&CLIB *NE 'NHPROD') +
THEN(CALLSUBR SUBR(EXSUBR))
Enddo