Re: EOF

[Charles Wilt <charles.wilt@xxxxxxxxx>]

Not true,

I can easily see scenarios where it works sometimes but not others.
Unless you have 100% test coverage, you could miss it.

Charles

On Fri, Nov 20, 2009 at 10:01 AM, David FOXWELL <David.FOXWELL@xxxxxxxxx> wrote:
> Come on, guys it only becomes toast if you modify it AND don't test it!
>
> Noone answered the second part, are there several levels of EOF? Ie one for each file and one for the last file read?
>
> > -----Message d'origine-----
> > De : rpg400-l-bounces@xxxxxxxxxxxx
> > [mailto:rpg400-l-bounces@xxxxxxxxxxxx] De la part de Colpaert, Peter
> > Envoyé : vendredi 20 novembre 2009 14:56
> > À : RPG programming on the IBM i / System i
> > Objet : RE: EOF
> >
> > And if someone adds an exsr after the read, and there is file
> > i/o in that subroutine, you're toast...
> >
> >
> > Peter Colpaert
> > Software Engineer, Consumer Luminaires
> > Industrieterrein Satenrozen 11, 2550 Kontich, Belgium Tel.
> > +32/ 3 450 74 09, Fax +32/ 3 450 74 33, Internal 1317
> > peter.colpaert@xxxxxxxxxxx, www.philips.com
> >
> >
> > > -----Original Message-----
> > > From: rpg400-l-bounces@xxxxxxxxxxxx [mailto:rpg400-l-
> > > bounces@xxxxxxxxxxxx] On Behalf Of
> > Tommy.Holden@xxxxxxxxxxxxxxxxxxxxx
> > > Sent: vrijdag 20 november 2009 14:26
> > > To: RPG programming on the IBM i / System i
> > > Subject: RE: EOF
> > >
> > > <snip>
> > > This will work today, but as someone pointed out, as soon
> > as someone
> > > adds another I/O, the routine becomes toast.
> > >
> > > I prefer to use my own indicator.  This will produce a considerably
> > > more stable application.  See the semi-pseudo code:
> > >
> > > DoU noMoreRecords ;
> > >    Select ;
> > >       When cond1 ;
> > >          Read file1 ;
> > >          noMoreRecords = %EOF(file1) ;
> > >       when cond2 ;</snip>
> > >
> > > not true.  if the new I/O is just adding a new file in a WHEN
> > > condition it will still work as designed without a problem.
> > >
> > >
> > > Thanks,
> > > Tommy Holden
> > >
> > >
> > >
> > > From:   "Dennis Lovelady" <iseries@xxxxxxxxxxxx>
> > > To:     "'RPG programming on the IBM i / System i'"
> > > <rpg400-l@xxxxxxxxxxxx>
> > > Date:   11/20/2009 07:21 AM
> > > Subject:        RE: EOF
> > > Sent by:        rpg400-l-bounces@xxxxxxxxxxxx
> > >
> > >
> > >
> > > > Will the test on EOF work correctly ? Will it be on if
> > either of the
> > > 3
> > > > files is at condition %EOF ? Do I need to check EOF for each file?
> > > >
> > > > Does an indicator EOF exist for all 3 files plus another that
> > > indicates
> > > > any of the files?
> > > >
> > > > Thanks!
> > > >
> > > > Select
> > > >     when cond1;
> > > >     read file1;
> > > >
> > > >     when cond1;
> > > >     read file2;
> > > >
> > > > etc
> > > >     other;
> > > >      read file3;
> > > >
> > > > EndSl;
> > > >
> > > > IF %EOF;
> > > >     etc
> > >
> > > This will work today, but as someone pointed out, as soon
> > as someone
> > > adds another I/O, the routine becomes toast.
> > >
> > > I prefer to use my own indicator.  This will produce a considerably
> > > more stable application.  See the semi-pseudo code:
> > >
> > > DoU noMoreRecords ;
> > >    Select ;
> > >       When cond1 ;
> > >          Read file1 ;
> > >          noMoreRecords = %EOF(file1) ;
> > >       when cond2 ;
> > >
> > > Etc.
> > > Dennis Lovelady
> > > http://www.linkedin.com/in/dennislovelady
> > > --
> > > "Politics is not a bad profession. If you succeed there are many
> > > rewards, if you disgrace yourself you can always write a book."
> > >         -- Ronald Reagan
> > >
> > >
> > >
> > > --
> > > This is the RPG programming on the IBM i / System i
> > (RPG400-L) mailing
> > > list To post a message email: RPG400-L@xxxxxxxxxxxx To subscribe,
> > > unsubscribe, or change list options,
> > > visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
> > > or email: RPG400-L-request@xxxxxxxxxxxx Before posting,
> > please take a
> > > moment to review the archives at
> > http://archive.midrange.com/rpg400-l.
> > > --
> > > This is the RPG programming on the IBM i / System i
> > (RPG400-L) mailing
> > > list To post a message email: RPG400-L@xxxxxxxxxxxx To subscribe,
> > > unsubscribe, or change list options,
> > > visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
> > > or email: RPG400-L-request@xxxxxxxxxxxx Before posting,
> > please take a
> > > moment to review the archives at
> > http://archive.midrange.com/rpg400-l.
> >
> >
> > The information contained in this message may be confidential
> > and legally protected under applicable law. The message is
> > intended solely for the addressee(s). If you are not the
> > intended recipient, you are hereby notified that any use,
> > forwarding, dissemination, or reproduction of this message is
> > strictly prohibited and may be unlawful. If you are not the
> > intended recipient, please contact the sender by return
> > e-mail and destroy all copies of the original message.
> > --
> > This is the RPG programming on the IBM i / System i
> > (RPG400-L) mailing list
> > To post a message email: RPG400-L@xxxxxxxxxxxx
> > To subscribe, unsubscribe, or change list options,
> > visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
> > or email: RPG400-L-request@xxxxxxxxxxxx
> > Before posting, please take a moment to review the archives
> > at http://archive.midrange.com/rpg400-l.
> --
> This is the RPG programming on the IBM i / System i (RPG400-L) mailing list
> To post a message email: RPG400-L@xxxxxxxxxxxx
> To subscribe, unsubscribe, or change list options,
> visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
> or email: RPG400-L-request@xxxxxxxxxxxx
> Before posting, please take a moment to review the archives
> at http://archive.midrange.com/rpg400-l.